themingbackground: Remove initializer that takes a GtkThemingEngine
authorBenjamin Otte <otte@redhat.com>
Mon, 16 Jun 2014 02:22:50 +0000 (04:22 +0200)
committerBenjamin Otte <otte@redhat.com>
Sat, 16 Aug 2014 17:39:44 +0000 (19:39 +0200)
With the unification to use style contexts everywhere, make that
initializer the only one to use.

Also rename it appropriately.

gtk/gtkcolorswatch.c
gtk/gtkthemingbackground.c
gtk/gtkthemingbackgroundprivate.h
gtk/gtkthemingengine.c

index 503d8f734bfe5068d75efa7d79b083229ab29a0f..b5329fa5ad8c3b0640c7057b7bcfac04ba29275e 100644 (file)
@@ -126,9 +126,9 @@ swatch_draw (GtkWidget *widget,
   gtk_style_context_save (context);
   gtk_style_context_set_state (context, state);
 
-  _gtk_theming_background_init_from_context (&background, context,
-                                             0, 0, width, height,
-                                             GTK_JUNCTION_NONE);
+  _gtk_theming_background_init (&background, context,
+                                0, 0, width, height,
+                                GTK_JUNCTION_NONE);
 
   if (swatch->priv->has_color)
     {
@@ -195,10 +195,10 @@ swatch_draw (GtkWidget *widget,
       GIcon *gicon;
 
       gtk_style_context_add_class (context, "color-active-badge");
-      _gtk_theming_background_init_from_context (&background, context,
-                                                 (width - 2 * ACTIVE_BADGE_RADIUS) / 2, (height - 2 * ACTIVE_BADGE_RADIUS) / 2,
-                                                 2 * ACTIVE_BADGE_RADIUS, 2* ACTIVE_BADGE_RADIUS,
-                                                 GTK_JUNCTION_NONE);
+      _gtk_theming_background_init (&background, context,
+                                    (width - 2 * ACTIVE_BADGE_RADIUS) / 2, (height - 2 * ACTIVE_BADGE_RADIUS) / 2,
+                                    2 * ACTIVE_BADGE_RADIUS, 2* ACTIVE_BADGE_RADIUS,
+                                    GTK_JUNCTION_NONE);
 
       if (_gtk_theming_background_has_background_image (&background))
         {
index 380eb5ad1ee694d28f7d10a4229492fb2d11a18e..413a928c8daf0978d2ea9b8cd6fcf292995b655a 100644 (file)
@@ -31,7 +31,7 @@
 #include "gtkcsspositionvalueprivate.h"
 #include "gtkcssrepeatvalueprivate.h"
 #include "gtkcsstypesprivate.h"
-#include "gtkthemingengineprivate.h"
+#include "gtkstylecontextprivate.h"
 
 #include <math.h>
 
@@ -308,31 +308,12 @@ _gtk_theming_background_init_context (GtkThemingBackground *bg)
 
 void
 _gtk_theming_background_init (GtkThemingBackground *bg,
-                              GtkThemingEngine     *engine,
+                              GtkStyleContext      *context,
                               gdouble               x,
                               gdouble               y,
                               gdouble               width,
                               gdouble               height,
                               GtkJunctionSides      junction)
-{
-  GtkStyleContext *context;
-
-  g_assert (bg != NULL);
-
-  context = _gtk_theming_engine_get_context (engine);
-  _gtk_theming_background_init_from_context (bg, context,
-                                             x, y, width, height,
-                                             junction);
-}
-
-void
-_gtk_theming_background_init_from_context (GtkThemingBackground *bg,
-                                           GtkStyleContext      *context,
-                                           gdouble               x,
-                                           gdouble               y,
-                                           gdouble               width,
-                                           gdouble               height,
-                                           GtkJunctionSides      junction)
 {
   g_assert (bg != NULL);
 
index 23fe092157382ae311841cd78cfd334994e07804..cb1f6000931dd2b3619257576247c9706cf5c9fb 100644 (file)
@@ -24,8 +24,8 @@
 #include <cairo.h>
 
 #include "gtkcssimageprivate.h"
-#include "gtkstylecontextprivate.h"
 #include "gtkroundedboxprivate.h"
+#include "gtktypes.h"
 
 G_BEGIN_DECLS
 
@@ -44,21 +44,13 @@ struct _GtkThemingBackground {
 };
 
 void _gtk_theming_background_init (GtkThemingBackground *bg,
-                                   GtkThemingEngine     *engine,
+                                   GtkStyleContext      *context,
                                    gdouble               x,
                                    gdouble               y,
                                    gdouble               width,
                                    gdouble               height,
                                    GtkJunctionSides      junction);
 
-void _gtk_theming_background_init_from_context (GtkThemingBackground *bg,
-                                                GtkStyleContext      *context,
-                                                gdouble               x,
-                                                gdouble               y,
-                                                gdouble               width,
-                                                gdouble               height,
-                                                GtkJunctionSides      junction);
-
 void _gtk_theming_background_render (GtkThemingBackground *bg,
                                      cairo_t              *cr);
 
index 1e5278499a254fa8d538948e1469aaa11d968d6b..98a297c05a83410a22ad5bbf3f23dff85cfc55d4 100644 (file)
@@ -20,7 +20,8 @@
 #include <math.h>
 #include <gtk/gtk.h>
 
-#include <gtk/gtkthemingengine.h>
+#include "gtkthemingengineprivate.h"
+
 #include <gtk/gtkstylecontext.h>
 #include <gtk/gtkintl.h>
 
@@ -38,8 +39,8 @@
 #include "gtkcsstransformvalueprivate.h"
 #include "gtkcsstypesprivate.h"
 #include "gtkhslaprivate.h"
-#include "gtkthemingengineprivate.h"
 #include "gtkroundedboxprivate.h"
+#include "gtkstylecontextprivate.h"
 #include "gtkthemingbackgroundprivate.h"
 
 #include "fallback-c89.c"
@@ -1385,7 +1386,7 @@ gtk_theming_engine_render_background (GtkThemingEngine *engine,
 {
   GtkThemingBackground bg;
 
-  _gtk_theming_background_init (&bg, engine,
+  _gtk_theming_background_init (&bg, engine->priv->context,
                                 x, y,
                                 width, height,
                                 gtk_theming_engine_get_junction_sides (engine));
@@ -2171,7 +2172,7 @@ gtk_theming_engine_render_extension (GtkThemingEngine *engine,
       break;
     }
 
-  _gtk_theming_background_init (&bg, engine, 
+  _gtk_theming_background_init (&bg, engine->priv->context
                                 x, y,
                                 width, height,
                                 junction);
@@ -2241,7 +2242,7 @@ gtk_theming_engine_render_handle (GtkThemingEngine *engine,
   color_shade (&bg_color, 0.7, &darker);
   color_shade (&bg_color, 1.3, &lighter);
 
-  _gtk_theming_background_init (&bg, engine, x, y, width, height, sides);
+  _gtk_theming_background_init (&bg, engine->priv->context, x, y, width, height, sides);
   has_image = _gtk_theming_background_has_background_image (&bg);
   _gtk_theming_background_render (&bg, cr);